Review Draft: Direct Image Binary With ZXing v3.5.0#5
Open
Conrad-T-Pino wants to merge 37 commits intojlepage:masterfrom
Open
Review Draft: Direct Image Binary With ZXing v3.5.0#5Conrad-T-Pino wants to merge 37 commits intojlepage:masterfrom
Conrad-T-Pino wants to merge 37 commits intojlepage:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For many years a client accumulated many image files and most are for email messages. The primary motivation for this change is direct access to image binary for inclusion in email message without any intermediate file operations and later HTTP requests.
Change summary:
Barcode.cfcandQRCode.cfccommon methods intoabstractZXing.cfccomponentZXing.cfcreadBinarymethod for use fromBarcode.cfcandQRCode.cfccomponentsindex.cfmandbarcode.cfmHTML 5 markupREADME.mdupdatesZXing
Codabarchange status:Codabarimplmentation changed breaking the thirdbarcode.cfmexampleAandNas start and end characters whereAis "standard" andNis "alternate"Nend character withAresolves the thirdbarcode.cfmexampleTesting status:
index.cfmandbarcode.cfmboth create their respective imagesThis submission is a draft for project review while we continue testing and deployment from this branch.