Skip to content

Review Draft: Direct Image Binary With ZXing v3.5.0#5

Open
Conrad-T-Pino wants to merge 37 commits intojlepage:masterfrom
Conrad-T-Pino:modern
Open

Review Draft: Direct Image Binary With ZXing v3.5.0#5
Conrad-T-Pino wants to merge 37 commits intojlepage:masterfrom
Conrad-T-Pino:modern

Conversation

@Conrad-T-Pino
Copy link

For many years a client accumulated many image files and most are for email messages. The primary motivation for this change is direct access to image binary for inclusion in email message without any intermediate file operations and later HTTP requests.

Change summary:

  • Translate CFML tags in components and templates into CFScript for brevity - we're Java hacks 😺
  • Refactor Barcode.cfc and QRCode.cfc common methods into abstract ZXing.cfc component
  • Add ZXing.cfc readBinary method for use from Barcode.cfc and QRCode.cfc components
  • index.cfm and barcode.cfm HTML 5 markup
  • ZXing version 2.1 to 3.5.0 upgrade
  • README.md updates

ZXing Codabar change status:

  • ZXing Codabar implmentation changed breaking the third barcode.cfm example
  • ZXing v2.1 accepts A and N as start and end characters where A is "standard" and N is "alternate"
  • ZXing v3.5.0 expects start and end characters from the same set, rejecting mixed set combinations
  • Replacing N end character with A resolves the third barcode.cfm example

Testing status:

  • index.cfm and barcode.cfm both create their respective images

This submission is a draft for project review while we continue testing and deployment from this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant