Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| def logger | ||
| @logger ||= Logger.new($stdout).tap do |log| | ||
| log.progname = self.name |
There was a problem hiding this comment.
Style/RedundantSelf: Redundant self detected.
| custom_base_url || "https://api.openmetrolinx.com/OpenDataAPI/api" | ||
| end | ||
|
|
||
| def logger |
There was a problem hiding this comment.
Lint/DuplicateMethods: Method GoTransit.logger is defined at both lib/go_transit.rb:68 and lib/go_transit.rb:78.
| @@ -1,3 +1,3 @@ | |||
| module GoTransit | |||
| VERSION = "1.0.2".freeze | |||
| VERSION = "1.1.2".freeze | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
I have noticed some uncaught edge cases with the API response. We need to add some response logging for debug purposes so we can find these edge cases and properly catch them. This change addresses the need by: * Add the ability to set a logger * Add flag to enable response logging * Bump version WWW
jmazur
force-pushed
the
jm-add-logging
branch
from
024e237 to
af29954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed some uncaught edge cases with the API response. We need to add some response logging for debug purposes so we can find these edge cases and properly catch them.
This change addresses the need by: