Made some suggestions for edits to code#1
Open
2025IanG wants to merge 1 commit intojmchs-robotics:mainfrom
Open
Made some suggestions for edits to code#12025IanG wants to merge 1 commit intojmchs-robotics:mainfrom
2025IanG wants to merge 1 commit intojmchs-robotics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that the motors actually know that they're supposed to stop
Make sure that when you update the shuffleboard, the code actually decides the speed. If you don't, the actual speed of the shake table won't update even if you press a different button on the shuffleboard
In the command, you'll notice I changed all the
== 1.0and== -1.0to> 0.95and< -0.95. This is just in case the joystick somehow doesn't output exactly 1 when it's pushed in a direction. The same also goes for why I did< 0.05when telling it when to stop. HOWEVER, as I am typing this, I realize I made a mistake in my code. The< 0.05should be `< 0.05 && > -0.05', because otherwise it wouldn't be able to go to the left or down.Other than that, all I got rid of was just some unnecessary stuff, and I did some formatting just so I could read the code better.