Class1datatypes #1
Conversation
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Jonathan, nice job, just a few minor changes and you'll be good to go. I would definitely suggest reviewing the difference between the boolean true and something evaluating to true. Go ahead, make your changes on the class1datatypes branch, push your changes to update the pull request. Then come back to the pull request on git hub, once the comments are addressed, press "merge" at the bottom.
| // Write a JavaScript program to display the current day and time. | ||
|
|
||
| function currentDateTime(){ | ||
| console.log(new Date()); |
There was a problem hiding this comment.
The logic is right, however the function call is a little off. Your function should return the new date, and you should call the function in a console.log to display.
function currentDateTime(){ return new Date(); } console.log(currentDateTime());
| // Write a JavaScript program to convert a number to a string. | ||
|
|
||
| function numberToString(num){ | ||
| console.log(num.toString()); |
There was a problem hiding this comment.
The logic is right, however the function call is a little off. Your function should return the new date, and you should call the function in a console.log to display.
| // Write a JavaScript program to convert a string to the number. | ||
|
|
||
| function stringToNumber(number){ | ||
| console.log(parseInt(number)); |
There was a problem hiding this comment.
The logic is right, however the function call is a little off. Your function should return the new date, and you should call the function in a console.log to display.
| // String | ||
|
|
||
| function ReturnType(someData){ | ||
| console.log(typeof someData); |
There was a problem hiding this comment.
The logic is right, however the function call is a little off. Your function should return the new date, and you should call the function in a console.log to display.
| // Write a JavaScript program that adds 2 numbers together. | ||
|
|
||
| function addingStuff(dig1, dig2){ | ||
| console.log( dig1 + dig2 ); |
There was a problem hiding this comment.
The logic is right, however the function call is a little off. Your function should return the new date, and you should call the function in a console.log to display.
| function trueTings (x, y){ | ||
| if(x === true && y === true) { | ||
| console.log("It's True!"); | ||
| } |
There was a problem hiding this comment.
The logic is right, however the function call is a little off. Your function should return the new date, and you should call the function in a console.log to display.
|
|
||
| // Write a JavaScript program that runs only when 2 things are true. | ||
| function trueTings (x, y){ | ||
| if(x === true && y === true) { |
There was a problem hiding this comment.
This function as is evaluates if x & y are equal to the boolean "true". So to get it to run you would have to pass in the literal boolean "true". I need the function to evaluate if x & y evaluate to true. if(x&y){...}
| function oneTingTrue (z, p) { | ||
| if (p || z === true) { | ||
| console.log("There can only be one"); | ||
| } |
There was a problem hiding this comment.
The logic is right, however the function call is a little off. Your function should return the new date, and you should call the function in a console.log to display.
| // Write a JavaScript program that runs when 1 of 2 things are true. | ||
|
|
||
| function oneTingTrue (z, p) { | ||
| if (p || z === true) { |
There was a problem hiding this comment.
This function as is evaluates if x is equal to the boolean "true". So to get it to run you would have to pass in the literal boolean "true". I need the function to evaluate if x or p evaluates to true.
|
|
||
| function noTrueTings (w, r) { | ||
| if (w != 2 && r != 13){ | ||
| console.log("Yeah right! Neither are true"); |
There was a problem hiding this comment.
The logic is right, however the function call is a little off. Your function should return the new date, and you should call the function in a console.log to display.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3