Skip to content

Only apply gradient overlays if a corresponding codec/resolution overlay is also being applied#6

Open
axel-devs wants to merge 6 commits intojmxd:mainfrom
axel-devs:main
Open

Only apply gradient overlays if a corresponding codec/resolution overlay is also being applied#6
axel-devs wants to merge 6 commits intojmxd:mainfrom
axel-devs:main

Conversation

@axel-devs
Copy link

Custom media_info.yml that only applies gradient_top or gradient_bottom if there is a corresponding codec/resolution also being applied. There was probably a better way to achieve this and I may have overlooked something, but it works great with my Kometa setup.

jmxd and others added 6 commits June 6, 2024 06:19
* Add more editions

Adds final cut, remastered, restored, signature, theatrical cut, theatrical/edition, extended cut, extended/edition, supports X year for anniversary edition.

* Add edition images

Adds images for new suggested editions/cuts

* Forgot remastered image

* Delete Super Cool Edition.png

Delete misnamed image

* Add uncut/ultimate + director tweak

Adds support for ultimate/ultimate edition, uncut, and captures ultimate director as a director's cut. Images included.
Custom media_info.yml that only applies gradient_top or gradient_bottom if there is a corresponding codec/resolution also being applied
@zhdenny
Copy link

zhdenny commented Jun 24, 2024

Just curious....what's wrong with using the flags which are already supported for Gradients? You can already decide to use or not use either top or bottom gradient.

use_gradient_bottom: false
use_gradient_top: true

@axel-devs
Copy link
Author

axel-devs commented Jun 24, 2024

Just curious....what's wrong with using the flags which are already supported for Gradients? You can already decide to use or not use either top or bottom gradient.

use_gradient_bottom: false
use_gradient_top: true

That doesn't automatically selectively apply them, it's either always on or always off. There is no check to see if the gradient is actually needed to be a backdrop for a corresponding overlay, so every poster gets the gradient no matter what. It looks pretty weird. I'd seen multiple other people ask for this, and having the gradient on every poster was bugging me too. This fixes that.

@zhdenny
Copy link

zhdenny commented Jun 24, 2024

Oh I see...I never noticed as I only apply this overlay setup to an extremely high-quality Plex Library - So every item has the gradients.

I also did some heavy edits privately to adjust where the overlays are to make it cleaner for my setup:
image

@axel-devs
Copy link
Author

axel-devs commented Jun 24, 2024

Oh I see...I never noticed as I only apply this overlay setup to an extremely high-quality Plex Library - So every item has the gradients.

The overlay works great for my extremely high-quality libraries too. But with such a massive library there's bound to be posters that were given a gradient overlay when they didn't need one.

@jmxd
Copy link
Owner

jmxd commented Jun 25, 2024

I've been meaning to look into the possibility of doing this but not gotten around to it.

One problem i'm seeing by doing it in this way is that it will only work with the default setup and break if people decide to change the position of the overlays. I'm also concerned that this would increase the processing time by a large amount, but i have not checked if that is actually the case.

Going to be putting this on hold for now, but appreciate it :)

@Mereks
Copy link

Mereks commented Feb 7, 2025

Oh I see...I never noticed as I only apply this overlay setup to an extremely high-quality Plex Library - So every item has the gradients.

I also did some heavy edits privately to adjust where the overlays are to make it cleaner for my setup: image

Not related and sorry to hijack but are these custom posters or via Posterizarr, if the latter I'd love to see your config, they look amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants