Properly format \n for multiline messages

[Yeraze]

No description provided.

[jnwatts]

I'm not sure I follow why this is needed: actual new lines are already preserved in the current implementation. Also, this commit also changes the config path, and be NAK'd for that :-)

…

On Fri, Sep 24, 2021, 8:08 AM Randall Hand ***@***.***> wrote: ------------------------------ You can view, comment on, or merge this pull request online at: #28 Commit Summary - Properly format \n for multiline messages <71c08ae> File Changes - *M* pushover.sh <https://github.com/jnwatts/pushover.sh/pull/28/files#diff-7be9dbbe7f6129de1ae24f8db926c9edc621bc06324d61774380eaa51572baab> (4) Patch Links: - https://github.com/jnwatts/pushover.sh/pull/28.patch - https://github.com/jnwatts/pushover.sh/pull/28.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#28>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSMYOYHWPGUELCCBFCO63UDRS5DANCNFSM5EV2CIMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Yeraze]

Yea I started to revise the commit to pull out the config path :).

I thought it would work like you say, but in my testing it did not.. For example, when I tried to send the message "Test line 1\ntest line 2" it came through as a single line.. This fixed it. Does it work for you?

[jnwatts]

The script itself isn't responsible for expanding escape codes, that should be the shell's job ;-) See #20 for a partial discussion on this, else what shell are you using? Most likely you need to be careful about using single vs double quotes to allow the to properly expand /and/ capture newlines.

…

On Fri, Sep 24, 2021, 1:27 PM Randall Hand ***@***.***> wrote: Yea I started to revise the commit to pull out the config path :). I thought it would work like you say, but in my testing it did not.. For example, when I tried to send the message "Test line 1\ntest line 2" it came through as a single line.. This fixed it. Does it work for you? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSMYOD66PZHPIY5GN4P53UDSYITANCNFSM5EV2CIMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Yeraze]

Ah, I see... Well I'm using bash, but my main use case for this script is connecting it to tools such as nagios, octopi, and apcupsd to send events.

[jnwatts]

Should be able to with those, just need to figure out how to correctly quote your arguments within each. Worst case you could write a trivial wrapper that does an extra escape-code decode step. 👍

…

On Sat, Sep 25, 2021, 8:41 AM Randall Hand ***@***.***> wrote: Ah, I see... Well I'm using bash, but my main use case for this script is connecting it to tools such as nagios, octopi, and apcupsd to send events. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSMYOKYKWSHRS6QH75QGDUDW7QHANCNFSM5EV2CIMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Yeraze]

Or I can just fix it in one place (this script) and use ‘\n’ everywhere 😉

[jnwatts]

Haha, yup! :-) I'd prefer not to add extra parsing to the default logic, but I'd be happy to take a change that is controlled by switch or environment variable 👍

…

On Sat, Sep 25, 2021, 9:38 AM Randall Hand ***@***.***> wrote: Or I can just fix it in one place (this script) and use ‘\n’ everywhere 😉 On Sat, Sep 25, 2021 at 9:28 AM Josh ***@***.***> wrote: > Should be able to with those, just need to figure out how to correctly > quote your arguments within each. Worst case you could write a trivial > wrapper that does an extra escape-code decode step. 👍 > > On Sat, Sep 25, 2021, 8:41 AM Randall Hand ***@***.***> wrote: > > > Ah, I see... Well I'm using bash, but my main use case for this script is > > connecting it to tools such as nagios, octopi, and apcupsd to send > events. > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub > > <#28 (comment) >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAGSMYOKYKWSHRS6QH75QGDUDW7QHANCNFSM5EV2CIMQ > > > > . > > Triage notifications on the go with GitHub Mobile for iOS > > < > https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > > > or Android > > < > https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub > >. > > > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#28 (comment)>, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABMFM7MNPO2YY46MG3MIJZTUDXE6JANCNFSM5EV2CIMQ > > . > Triage notifications on the go with GitHub Mobile for iOS > < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 > > or Android > < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub >. > > -- < https://about.me/randall.hand?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb > Randall Hand about.me/randall.hand < https://about.me/randall.hand?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSMYOWCPS5QO2Q2NCM2Y3UDXGGDANCNFSM5EV2CIMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[Yeraze]

Not trying to be argumentative, but do you really think there are a significant number of people passing \n through your script that actually want it printed raw as \n ? Just seems to be like converting it to a carriage return would be the obvious preferred output.