feat: add TypeScript module for Python run configuration#1
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
feat: add TypeScript module for Python run configuration#1devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
Migrate TRunConfiguration class and TPythonControl.Run/Debug methods from Delphi cPyControl.pas to TypeScript/Node.js. Features: - RunConfiguration interface with script path, arguments, working directory, and environment variables - PythonRunner class with run() and debug() methods - DebuggerState enum matching Delphi TDebuggerState - PythonEngineType enum matching Delphi TPythonEngineType - Cross-platform support (Windows, macOS, Linux) - Error handling for missing Python, scripts, and directories - Event emitter for stdout, stderr, exit, and state changes - Output file writing support - Prepared for future DAP integration Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new TypeScript/Node.js module that migrates the
TRunConfigurationclass andTPythonControl.Run/Debugmethods from the Delphi codebase (Source/cPyControl.pasandSource/cPySupportTypes.pas) to TypeScript.The module provides:
RunConfigurationinterface with script path, arguments, working directory, and environment variablesPythonRunnerclass withrun()anddebug()methods using Node.jschild_process.spawn()DebuggerStateandPythonEngineTypeenums matching the original Delphi typesThe debug functionality currently uses Python's built-in
pdbmodule and is structured to support future DAP (Debug Adapter Protocol) integration.Review & Testing Checklist for Human
run()anddebug()work correctly with real Python scripts on your target platformpause()andresume()methods use Unix signals (SIGSTOP/SIGCONT) which are no-ops on Windows. Confirm this is acceptableBreakpointInfointerface is defined inDebugOptionsbut is not actually used inbuildDebugArgs(). Determine if breakpoint support should be implemented or removedpdbwhich provides basic debugging. Verify this meets requirements or if more sophisticated debugging is neededTest Plan
print("hello"))const result = await run({ scriptPath: '/path/to/script.py' })initStepIn: trueto confirm pdb launches correctlyNotes
npm run buildsucceedsnpm run lintsucceeds (with TypeScript version warning)ts-src/directory as a new TypeScript project within the repoLink to Devin run: https://app.devin.ai/sessions/f5aa9b6e7b64408f9ff935d3eee99b31
Requested by: Joao Esteves (@joao-cognition)