More clear state flags for OCE states#796
Draft
sticks-stuff wants to merge 2 commits intojoaorb64:mainfrom
Draft
More clear state flags for OCE states#796sticks-stuff wants to merge 2 commits intojoaorb64:mainfrom
sticks-stuff wants to merge 2 commits intojoaorb64:mainfrom
Conversation
Contributor
Author
|
As requested by @joaorb64, this might work better if/when there are custom country/state flags, as the flags in TSH come from a different project that is automated (I was unaware of this). As such, I've updated this PR to move the flags to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most people in OCE don't even know what their state flag is, much less recognize it in an overlay.
I've replaced these somewhat useless state flags in AUS with Kaiza's custom state icons, which have been commonplace in AUS smash streams for a few years now. I've also designed some for NZ regions as well.
Note that in cases where there are active locals, I've put the city over the region for those players since that's generally the identity of the scene, so:
WKO -> HAM
CAN -> CHC
OTA -> DUN
MWT -> PMN
TKI -> NPL
NTL -> WRE
BOP -> TRG
Bay of Plenty is definitely the most complex, as both Rotorua and Tauranga has had locals in the past. However, there are currently no locals in either region, and Tauranga is 3x the size of Rotorua. Worst case scenario, it's a little odd in the case that somehow there ends up being both Tauranga and Rotorua locals.
3 letter abbreviations are derived from my own knowledge of what Kiwi's would know as each region - plus https://service.unece.org/trade/locode/nz.htm in cases where I didn't really know (just New Plymouth, Whangārei, Tauranga).