Skip to content

Trivial fixes to work with python 3 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jpolton wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Trivial fixes to work with python 3 #4

jpolton wants to merge 2 commits into from

Conversation

@jpolton
Copy link

@jpolton jpolton commented Apr 13, 2022

No description provided.

@jobisoft
Copy link
Owner

jobisoft commented Apr 13, 2022

Thanks. Will it still work with python 2 after these changes?

@jpolton
Copy link
Author

jpolton commented Apr 19, 2022

Thanks. Will it still work with python 2 after these changes?

That is a really good point! No it wouldn't. So I have added a legacy file wikidoc_py27.py which was your old wikidoc.py as a simple way to keep your repo alive (at python3) and usable (at python2). Alternative approaches might be using a "git release" but that seems like overkill and not as convenient or intuitive for legacy users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpolton @jobisoft