Fix for GitHub save failing#68
Open
davekobrenski wants to merge 7 commits intojocelyn-stericker:mainfrom
Open
Conversation
✅ Deploy Preview for hacklily ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi, I'm also having trouble saving files, is there a reason preventing this fix to be applied? Thanks :) |
|
Same here. Would be really nice to get this merged @jocelyn-stericker 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #55, resolves #33
Saving to GitHub was failing due to process.env not being available on the client side. Adding a few lines to the webpack.config.js fixes this.
Also, I updated the README.md as the makefile doesn't exist, so the
make servecommand is outdated? I updated the readme with the commands that (I think) should be run instead. I should note that I was getting an error withyarn buildbut not withnpm run build. The yarn error had something to do with the enhanced-resolve npm plugin and the normalize.css file in src.Love your work on this, btw. Really nice and useful.