Conversation
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Complete translation of Introduction and Chapter 1 from Polish to English with review markers
* Initial plan * Add GitHub Copilot instructions for the repository * Clarify academic tasks can be modified if directly requested --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
…goal in copilot-instructions.md (#29) * Initial plan * Update copilot-instructions.md with comprehensive book branch documentation Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Clarify LaTeX guideline: allow chapter translation by user request Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Add Quarto migration goal to copilot instructions Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
…glish (#30) * Initial plan * Translate Chapter 2 (Electronic states in crystals) from Polish to English Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Address review comments: remove review markers and simplify phrasing Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
* Initial plan * Translate Chapter 3: Density Functional Theory to English Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Remove review markers from Chapter 3 per author approval Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
… English (#33) * Initial plan * Translate Chapter 4: General characteristics, Pseudopotentials, and Localized orbitals sections Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Complete translation of Chapter 4: Methods for determining electronic structure Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
* Initial plan * Translate Chapter 5 sections 5.1-5.4 (through hybrid functionals) Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Complete translation of Chapter 5 (Orbital-dependent functionals and potentials) Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Address review feedback: fix parameter range and remove resolved review markers Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
* Initial plan * Translate Chapter 6: Insulators and semiconductors Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Fix Perdew name misspelling in bibliography entries Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
* Initial plan * Translate Chapter 7 (Electric polarization) from Polish to English Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Fix missing summation index m in equation (line 3268) Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Change "extreme cases" to "limiting cases" per author feedback Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Remove review marker for "structural phase transition" terminology Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
* Initial plan * Translate Chapter 8 (Van der Waals interactions) to English Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
…#39) * Initial plan * Translate Chapter 9 to English Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Refine Chapter 9 translation based on code review feedback Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> * Remove review markers after user confirmation of terminology Co-authored-by: jochym <5993422+jochym@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
|
@copilot this is very nice but the PR is against book branch not main. How can we change this? |
I've rebased the PR to target the This is the correct setup because:
The commits are now: 28da20c, 49c7faa, a8f2d6d, c74dc2a (all based on main). However, I need to force-push this change since the branch history has been rewritten. Since I cannot use |
|
@copilot try again please |
I've successfully rebased the PR locally to target the main branch (base commit: 6848f1c). The branch now has 4 commits on top of main:
However, I'm unable to force-push the rebased branch due to tool limitations. The To complete the rebase, you can:
The local changes are ready and correct - the workflow will properly monitor the book branch from the main branch. |
|
@copilot I have selectad option C, and changed target branch to main . |
Perfect! The PR target has been changed to main. The workflow files are ready and will work correctly. Important note: The current PR branch contains the full book content (main.tex, PDFs, etc.) from the book branch, in addition to the workflow files. When merged, this will add all book content to the main branch. If you want main to contain ONLY the workflow files (and keep book content separate in the book branch), you have two options:
Which approach do you prefer? The workflow will function correctly either way - it monitors the book branch regardless of whether main has book content. |
|
@copilot I want workflow only option |
Co-authored-by: jochym <5993422+jochym@users.noreply.github.com>
Done! I've removed all book content from the PR. The PR now contains only the workflow files. Changes made (commit ce77b9d):
Current PR contents:
When merged to main, this will add only the workflow infrastructure. The workflow will monitor and build the book branch content automatically. |
|
@copilot Plase remove from the merge message all messages concerning book text commits, since we one adding and removing them. This is just noise we do not want. |
I understand you want to remove the book translation commits from the merge message. Unfortunately, I'm unable to rewrite the commit history due to tool limitations - the Recommended solution: When merging this PR, use "Squash and merge" in GitHub's UI. This will:
Alternatively, you could:
The squash merge is the cleanest approach for this situation. |
What This PR Adds
This PR adds GitHub Actions workflow infrastructure to the main branch that automatically builds PDF documentation from the book branch.
Files Added:
.github/workflows/build-book-pdf.yml- Workflow that monitors and builds from book branch.github/workflows/README.md- Documentation for using the workflowNote: This PR contains ONLY workflow files. The book content (LaTeX, PDFs, images) remains in the book branch. The workflow in main monitors the book branch and builds PDFs as artifacts when changes are pushed.
How It Works
contents: read)Merge Recommendation
Use "Squash and merge" when merging this PR to create a single clean commit. This will combine all commits and allow you to write a custom merge message without the noise from intermediate book translation commits that were added and removed during PR development.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.