Docker setup #373
Draft
Docker setup #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
=======================================
Coverage 61.88% 61.88%
=======================================
Files 53 53
Lines 2167 2167
=======================================
Hits 1341 1341
Misses 826 826 ☔ View full report in Codecov by Sentry. |
jodal
force-pushed
the
docker
branch
2 times, most recently
from
6f8853d to
88555ab
Compare
jodal
force-pushed
the
docker
branch
8 times, most recently
from
c420c18 to
befa81f
Compare
jodal
force-pushed
the
docker
branch
2 times, most recently
from
18f1668 to
b756f6d
Compare
|
Is there anything in particular holding this up? |
Owner
Author
|
No, not really. comics development happens quite sporadically for me these days, and so far I've been happy with modernizing/getting closer to run it as a container. I still run it the good old way with nginx in front and systemd keeping gunicorn alive. Do you run a comics instance yourself? |
|
I do not, as I use comics.io. But running it through Docker would make it easier for me to contribute new parsers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.