[WIP] React lint WIP - DO NOT MERGE#20
Draft
brody4hire wants to merge 2 commits intojoefazz:masterfrom
Draft
Conversation
brody4hire
force-pushed
the
react-lint-wip
branch
from
9248d21 to
61c4fc8
Compare
NOTE that this has a trick to use eslint-config-standard-jsx to quickly get a very basic working set of eslint rules working with React that is up-to-date. TODO: we need a new eslint config package that is designed to gives us the basic set of working eslint rules without using this kind of a trick.
brody4hire
force-pushed
the
react-lint-wip
branch
from
61c4fc8 to
cd27198
Compare
…starter into react-lint-wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this WIP PR includes the changes I proposed in PR #17.
This is a trick to use
eslint-config-standard-jsxwithouteslint-config-standardto get some very basic React code linting.This PR includes an additional change to require the logo image exactly once at the beginning of the module, which should be both cleaner and slightly more efficient.
The motivation is that
eslint-plugin-reactneeds some extra configuration to getplugin:react/recommendedworking andeslint-config-reactseems to be pretty badly outdated.I am planning to make a new, cleaner eslint-config package in the near future, would like to finish some higher-priority tasks first.
ref: #19 - very basic linting