Skip to content

Small improvements #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Small improvements #6

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
696f11d
Fixed possible initial lag or unrensponsiveness
albertogasparin Jun 29, 2012
a541dd7
Changed height calc in order to ignore borders
albertogasparin Jun 29, 2012
d6200f0
Prevent page scroll where the content is smaller than visible area
albertogasparin Jun 29, 2012
7db868a
Fixed wrong event binding
albertogasparin Jun 29, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions scrollfix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

var ScrollFix = function(elem) {
// Variables to track inputs
var startY, startTopScroll;
var startY, startTopScroll = 0, disableScroll = false;

elem = elem || document.querySelector(elem);

Expand All @@ -25,7 +25,17 @@ var ScrollFix = function(elem) {
if(startTopScroll <= 0)
elem.scrollTop = 1;

if(startTopScroll + elem.offsetHeight >= elem.scrollHeight)
elem.scrollTop = elem.scrollHeight - elem.offsetHeight - 1;
if(startTopScroll + elem.clientHeight >= elem.scrollHeight)
elem.scrollTop = elem.scrollHeight - elem.clientHeight - 1;

disableScroll = (elem.scrollHeight <= elem.clientHeight);
}, false);

// Page should not scroll when the content does not fill the area
elem.addEventListener('touchmove', function(event){
if(disableScroll) {
event.preventDefault();
}
}, false);

};