Skip to content

Use same segpi for cross validation iterations #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achilleasNP wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use same segpi for cross validation iterations #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/SNPs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,10 +742,14 @@ double SNPs::cross10(bool penalize){
// L = 1/10* \sum_i L*(i)
// where L*(i) is the likelihood of data in group i after optimizing model without it
//
double initial_segpi = segpi; // Store local segpi
double toreturn =0;
vector< set<int> > split10 = make_cross10();
vector<double> Lstar;
for (vector<set<int> >::iterator it = split10.begin(); it != split10.end(); it++){
// Ensure the use of local segpi and not the estimated one from the previous
// cross validation
segpi = initial_segpi;
GSL_xv_optim(*it, penalize);
double tmpl = 0;
for (set<int>::iterator it2 = it->begin(); it2 != it->end(); it2++) tmpl += llk(*it2);
Expand Down