This repository was archived by the owner on Jun 20, 2025. It is now read-only.
Add support for using with react-router v3 which uses history v3.#55
Open
walokra wants to merge 2 commits intojoernroeder:masterfrom
Open
Add support for using with react-router v3 which uses history v3.#55walokra wants to merge 2 commits intojoernroeder:masterfrom
walokra wants to merge 2 commits intojoernroeder:masterfrom
Conversation
The first tracking fails as it tries to look for page history.location which was added in history v4 and replaced history.getCurrentLocation() function in history v3.
Owner
|
hey @walokra, thanks for your contribution. i would love to merge your changes but would please you to add an additional test to the suite to cover the following line https://coveralls.io/builds/17947610/source?filename=index.js#L185 as well as following code styles by ending lines with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first tracking fails as it tries to look for page history.location which was added in history v4 and replaced history.getCurrentLocation() function in history v3.