Delegate and UI improvements#24
Open
andrei-sadagurschi wants to merge 11 commits intojohankasperi:masterfrom
Open
Delegate and UI improvements#24andrei-sadagurschi wants to merge 11 commits intojohankasperi:masterfrom
andrei-sadagurschi wants to merge 11 commits intojohankasperi:masterfrom
Conversation
andrei-sadagurschi
commented
Jun 13, 2017
andrei-sadagurschi
commented
- added color picker delegate for getting notified when the color changes;
- added conversion from extended RGB space to sRGB for iOS 10.0 and above (sometimes the returned colors need to be used in sRGB with red, green and blue values between 0.0 and 1.0);
- fixed compile warnings;
- don't recreate color wheel, brightness view and selected color view each time the color is set from outside;
- added laryer corner radius and border to selected color view;
…w each time the color is set from outside; - added laryer corner radius and border to selected color view;
jordanhbuiltbyhq
left a comment
jordanhbuiltbyhq
left a comment
There was a problem hiding this comment.
Looking good. It would be better to use CGFloat.pi instead of CGFloat(Double.pi). Could remove the print() statements in setupIfNeeded.
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.