chore: optimize docker image size (50% reduction)#483
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
2 issues found across 8 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docker/migrate.js">
<violation number="1" location="docker/migrate.js:33">
P1: Missing PostgreSQL advisory lock — concurrent container starts can cause duplicate or conflicting migration runs.
Prisma's `migrate deploy` acquires `pg_advisory_lock(72707369)` before checking/applying migrations to serialize concurrent runners. Without this, two containers starting simultaneously will both see the same pending migrations and race to apply them, which can corrupt the schema or cause errors.
Acquire the lock right after `CREATE TABLE` and it will auto-release when the connection ends in the `finally` block.</violation>
<violation number="2" location="docker/migrate.js:70">
P2: If `ROLLBACK` itself fails (e.g., connection lost), the original migration error is swallowed. Wrap the `ROLLBACK` in a try/catch to preserve the original error for debugging.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Down from around 330MB compressed to 140MB compressed
Summary by cubic
Reduced Docker image size by ~50% (≈330MB → ≈140MB) by moving Bun to build-only and running the app on node:22-slim. Also replaced Prisma CLI migrations with a lightweight Node runner and switched to @sveltejs/adapter-node.
Refactors
Migration
Written for commit 4d98681. Summary will update on new commits.