Updates for compatibility with recent updates#37
Open
mohller wants to merge 11 commits intojoheinze:masterfrom
Open
Updates for compatibility with recent updates#37mohller wants to merge 11 commits intojoheinze:masterfrom
mohller wants to merge 11 commits intojoheinze:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses incompatibilities in the code with recent versions of SciPy. In particular, fixes to avoid deprecated functions (trapz, cumtrapz, interp2d) and some other fixes to address issues produced by the updated functions. The largest piece of code is a trivial class to hold the interpolating function for ebl models, in order to address the deprecation of interp2d properly. This class was needed in particular to allow pickle.dump of the kernel, as a simpler lambda function (see 98c8871 and 4e5a0fb) worked well, but raised errors when trying to pickle.dump a precomputed kernel.
This updates have been verified by running the three basic examples in https://github.com/joheinze/PriNCe-examples#1c6e7930c5edbe13c41910c61ce09c86eb491e65 which was not possible before the changes in this PR when using the latest SciPy 1.17.