Migrate to dotenv parser #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
midnight-wonderer
force-pushed
the
feature/dotenv-parser
branch
from
bf90d1d to
5807dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I just discovered this project today; thanks.
The Issue
Some people are having trouble with
Parser.phpfor some times. #6 #9And I was very surprised to know that PCRE has been used for the parser.
How about we just use Dotenv just for the parser?
This way you don't have to maintain the code here, leveraging on the community.
Notes
??=syntax required PHP 7.4; I bump the requirement as the result. Older PHP versions can still use the current release, since they are feature compatible.What do you says?
Sound good?
P.S. I know that Laravel has a similar feature already; I use this on a CodeIgniter project.