Full Maven refactoring #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple markdown adjustment for examples using `code`
git directory exclusions do not need `*` for depth, see [Pattern Format](http://git-scm.com/docs/gitignore#_pattern_format). Added exclusions for IntelliJ and Mac OS X. Some minor organization.
Source encoding. Compiler props. Add `licenses`. Add LICENSE.txt.
Refactored the test packages to Maven defaults and removed the `sourceDirectory` element from the compiler plugin for a cleaner build.
BBC reorganized URIs and moved to HTTPS
Build out the POM meta-data.
A full refactoring of the project to take advantage of Maven. Refactoring includes naming, multi-module build, and more. Updated the URL for the BackToTheFuture example to use an archived version of the RottenTomatoes website at archive.org at the time of the original commit . Changes at RottenTomatoes prevented this from working. Maven GAV was refactored to use case normalization. The build creates an executable JAR (with dependencies). Update the SNAPSHOT version.
Use the archive.org version for the movie at the time that the class was first committed to the project.
As shown below, numerous refactorings took place. The refactoring builds a multi-module maven project and sets up the project for leveraging additional features of maven. Provide formatting for examples Simple markdown adjustment for examples using `code` Provide additional exclusions and organize git directory exclusions do not need `*` for depth, see [Pattern Format](http://git-scm.com/docs/gitignore#_pattern_format). Added exclusions for IntelliJ and Mac OS X. Some minor organization. Add License and update POM Source encoding. Compiler props. Add `licenses`. Add LICENSE.txt. Fix UTF characters from test page. Refactor test packages, remove defaults from POM Refactored the test packages to Maven defaults and removed the `sourceDirectory` element from the compiler plugin for a cleaner build. Fix tests using BBC BBC reorganized URIs and moved to HTTPS Complete more POM meta-data Build out the POM meta-data. Refactor project for multi-module maven build A full refactoring of the project to take advantage of Maven. Refactoring includes naming, multi-module build, and more. Updated the URL for the BackToTheFuture example to use an archived version of the RottenTomatoes website at archive.org at the time of the original commit . Changes at RottenTomatoes prevented this from working. Maven GAV was refactored to use case normalization. The build creates an executable JAR (with dependencies). Update the SNAPSHOT version. Fix the RottenTomatoes link Use the archive.org version for the movie at the time that the class was first committed to the project.
… into maven-polish
… into maven-polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to take advantage of more maven so refactored the project as a multi-module maven project.
Some additional work is in flight, but this really advances the project to leverage more Maven and gets rid of the last remnants of ant, i.e., the
build.xmlin the examples directory is replaced as part of the PR to use a module levelpom.