Exporting error (4xx/5xx) entries to Nginx config#2669
Open
EvanK wants to merge 4 commits intojohngodley:trunkfrom
Open
Exporting error (4xx/5xx) entries to Nginx config#2669EvanK wants to merge 4 commits intojohngodley:trunkfrom
EvanK wants to merge 4 commits intojohngodley:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error code redirects (eg, a
410to "kill" a url for SEO purposes or a451for legal takedowns) are not correctly exported in the nginx format, which this PR aims to fix.Example data
Given this set of examples (a single redirect, the rest are error codes):
What happens now
They're currently exported as
rewritedirectives without a target, all of which will effectively 404:Ideal output
Instead, a
locationblock returning the error code seems to do the trick:Note that, for non-regex entries tagged with case insensitivity, the easiest way to accomplish that was to use it as an (escaped) regex with a case insensitive modifier (
~*). Any other non-regex can use the exact match modifier (=).Loose ends
I've added some tests for these cases, but was unable to run them locally to verify ahead of time. 🤞