Skip to content

Comments

Fix log/404 page date ordering#4164

Merged
johngodley merged 1 commit intotrunkfrom
fix/log-date-order
Feb 21, 2026
Merged

Fix log/404 page date ordering#4164
johngodley merged 1 commit intotrunkfrom
fix/log-date-order

Conversation

@johngodley
Copy link
Owner

It was using the wrong column ID

It was using the wrong column ID
Copilot AI review requested due to automatic review settings February 21, 2026 07:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes default date ordering behavior for the Logs and 404s log pages by ensuring the UI uses the correct “date” column identifier while keeping API sorting semantics intact.

Changes:

  • Default orderBy to 'date' in the LogPage table model when the stored orderby is empty.
  • Treat 'date' as the implicit/default sort by storing orderby: '' when the user selects the Date column (logs page).
  • Adjust 404 “Show All” row action to use the URL (instead of the numeric row id) when not grouped.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/page/logs404/row-actions.tsx Changes “Show All” filter value when not grouped to use row.url.
src/page/logs404/index.tsx Defaults LogPage orderBy to 'date' when table orderby is empty.
src/page/logs/index.tsx Maps UI date sort to empty orderby (API default) and defaults LogPage orderBy to 'date'.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@johngodley johngodley merged commit e01c5a6 into trunk Feb 21, 2026
12 checks passed
@johngodley johngodley deleted the fix/log-date-order branch February 21, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant