Merged
Conversation
It was using the wrong column ID
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes default date ordering behavior for the Logs and 404s log pages by ensuring the UI uses the correct “date” column identifier while keeping API sorting semantics intact.
Changes:
- Default
orderByto'date'in the LogPage table model when the storedorderbyis empty. - Treat
'date'as the implicit/default sort by storingorderby: ''when the user selects the Date column (logs page). - Adjust 404 “Show All” row action to use the URL (instead of the numeric row id) when not grouped.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/page/logs404/row-actions.tsx |
Changes “Show All” filter value when not grouped to use row.url. |
src/page/logs404/index.tsx |
Defaults LogPage orderBy to 'date' when table orderby is empty. |
src/page/logs/index.tsx |
Maps UI date sort to empty orderby (API default) and defaults LogPage orderBy to 'date'. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was using the wrong column ID