Open
Conversation
Still need to handle mismatches, and re-syncing streams.
Lookahead characters to see if the stream needs to be resynced in order to get better evaluation results
When the stream finds the first candidate sync spot it should stop. If there were multiple candidate characers in a row it would incorrectly greedily grab too many.
Fixed debug of end of lines.
Was missing あ for some reason...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First alpha of the evaluation classes.
Need to run this against more of my test data to see if it is complete, and probably need to write the Comparison classes to check different outputs to find which is better.