Skip to content

Chat Improvements#33

Open
JorenC wants to merge 105 commits intomainfrom
Flags
Open

Chat Improvements#33
JorenC wants to merge 105 commits intomainfrom
Flags

Conversation

@JorenC
Copy link
Collaborator

@JorenC JorenC commented Feb 24, 2025

Hi John,

Worked with Trae.ai on a lot of changes.

  • Channel-list now hides the player
    I added a bit of business logic - if the player looks at an active game, it will only show the other players in the chat.
    Since after a game finishes all text are released, it then shows all the participants, not hiding the current player.
  • The channel-list now calls ChannelGroupAvatars.
    This is a circular component that shows all the flags. It has a fallback of using the playercolour and first letter of the nation.
  • The "Channel" title of the secondary screen is now changed into the participants of the channel.
    This works, but the issue is that the secondary panel becomes too large. I've tried with Trae to find the culprit - max-widthing the typography or it's parent is not the issue, it's somewhere higher up the hierarchy. While the typography can resize to the right size, the grid will consider it's original size, it seems. I need help here.

These changes are a significant improvemnet to the chat, but please

  • let me know how you feel about me working with Trae. I can do much more - like you said a game changer - but I'm not sure how good the code is I produce now.
  • can you help fix the width issue for the chat (e.g. development game with many players). What I want is for this to become a flexbox that grows down - so even in a game of Chaos (32 players), we can see all the names. I can grow it down fine (flexbox, needs some padding on the top above the typography), but the width issue I can't fix - the paper element becomes too large pushing the whole screen sideways.

johnpooch and others added 30 commits January 4, 2025 11:14
Update favicon and change document title to Diplicity
Add phase select functionality to game details screens
Update README to reflect project details and setup instructions
Fix issue with selectedPhase deleting all qs params
…ion; implement tests and update order handling
…onsolidate logic in useFindGames and useMyGames
…ructure and add logo image; update My Games image size
…etailAppBar with a divider and improve orders display message
…nent for displaying orders alongside the game map
John McDowell and others added 28 commits February 14, 2025 11:36
… environments; update package dependencies
- Added avatar (to be fixed into new component)
- Added max characters for preview
- Removed whitespace to have more text on screen.
- Moved the player title to the date caption to save space
- Aligned the avatars in the chat overview to the top, so multiline message previews align properly.
- Removed spacing for the date selector to remove unnecessary whitespace
Changed some Root colours to Dip colours so they don't appear purple by default if not defined.
Failed to understand. Try again later.
- Removed unnecessary whitespace for the orders.
- Added double dividers for the nation order title
- Fixed outline for tabs issue.
Updated the map size to reduce white space and have it appear bigger. Includes a maximum width of the whole map area for big screens.
Didn't define/need this one
- Added an index in the chat to remind players hwo they are chatting with.
- Added the avatars to hide the player if game is active, show if finished.
- changed the channel names to the same logic as above
- Removed whitespace in the create-channel to fit for purpose.
- Removed a crash because of exposing the flag logic.
@JorenC JorenC changed the title NationAvatars and Flags Chat Improvements Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants