Open
Conversation
Update favicon and change document title to Diplicity
Add phase select functionality to game details screens
Update README to reflect project details and setup instructions
Fix issue with selectedPhase deleting all qs params
Add order outcomes
…utton for consistent styling
…ion; implement tests and update order handling
…onsolidate logic in useFindGames and useMyGames
…ructure and add logo image; update My Games image size
…etailAppBar with a divider and improve orders display message
…nent for displaying orders alongside the game map
…rs hook for improved order management
Limited to 18 players.
Maximum is now 10 players, after that it adds the button - otherwise it doesn't.
Chase away players
Chase them away
Johnpooch/interactive map
… environments; update package dependencies
…, and enhance login screen styling
…d components and context
…omponents; enhance API response schema with links
Moved player name to overflow menu if screen is small. Changed the 'back' button to a 'close' button on the game screen - to prevent it from conflicting with the back button in chat.
When there is a navigation menu, we don't need a back button - it actually interferes. So I removed it, as well as references to the profile. Finally, changes another back icon to X for the desktop game screen
When the user uses mobile, the 'create game' option is removed from the side menu/bottom menu and added as a FAB to the game list. This saves main navigation space (and confusion) for an option that is not often used. We should actually try to NOT let people first make games, but join one first. On desktop we have more than enough real estate though, so can keep it in the side menu.
When going back in the create game or game details, you now return to the correct back screen.
Added 24 padding around the circular loader so it doesn't look like an error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made quite some changes to improve the homescreen organisation:
Changed navigation to remove a lot of 'back' buttons that are actually not 'back'.
Added a 'close' icon to the game screen, to prevent it conflicting with the back in chat (on mobile)
Removed the profile option and moved it to the app bar
Added app bar to highlight the application/title/logo always on top
Removed 'create game' on the homescreen for mobile as it is secondary action.
Ideally, the "create game" has a state with just the title and no back/close button (for desktop).
I felt it was overkill to make it (complicated), so now it just hides it (it's in the side menu). WDYT?
Bugs: