fixed count() used with non countable parameter#35
Open
francescozanoni wants to merge 1 commit intojokkedk:masterfrom
francescozanoni:master
Open
fixed count() used with non countable parameter#35francescozanoni wants to merge 1 commit intojokkedk:masterfrom francescozanoni:master
francescozanoni wants to merge 1 commit intojokkedk:masterfrom
francescozanoni:master
Conversation
…plements Countable'
|
It is needed in PHP 8.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, man.
The issue I aim to fix is
Warning: count(): Parameter must be an array or an object that implements Countable.I'm aware this is related only to PHP >= 7.2, but I think it's a costless and safe improvement, worth to be implemented.
Thanks in advance!
Francesco