allow jolo-like did methods with a different prefix#441
Open
chunningham wants to merge 2 commits intonextfrom
Open
allow jolo-like did methods with a different prefix#441chunningham wants to merge 2 commits intonextfrom
chunningham wants to merge 2 commits intonextfrom
Conversation
Exulansis
requested changes
Nov 16, 2020
Collaborator
Exulansis
left a comment
Exulansis
left a comment
There was a problem hiding this comment.
Looks good!
This could use a test or two to ensure that the correct DID prefix is propagated (e.g. across created DID Documents, Signed Credentials, as part of recovery). Especially to ensure we don't accidentally break this functionality later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows for DID methods with the same architecture as
did:jolobut a different anchoring network to easily integrate with the library