test(agent-orchestrator): add model type tests after recipe-path refactor#1129
Open
test(agent-orchestrator): add model type tests after recipe-path refactor#1129
Conversation
…ath refactor Add model_test.go covering JSON serialization of AgentInfo (verifying the new RecipePath field and omitempty), JobStatus constants, JobRecord pipeline fields, PipelineStep conditions, GooseResult, and SubmitRequest optional fields. Register the new test file in both Bazel test targets in BUILD. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
f956802b(and its parent52022e97) refactoredmodel.goto replaceRecipe map[string]any+Model stringonAgentInfowith a singleRecipePath stringfieldmodel.gohad no correspondingmodel_test.go— this PR adds onemodel_test.gocovers JSON serialization key behaviors:recipePathJSON key,omitemptyon emptyRecipePath,JobStatusstring constants,JobRecordpipeline fields (PipelineID,StepIndex,StepCondition),PipelineStepconditions,GooseResultpipeline field, andSubmitRequestoptional fieldsmodel_test.goin bothorchestrator_unit_testandorchestrator_testtargetsTest plan
bb test //projects/agent_platform/orchestrator:orchestrator_unit_testpasses locally (all 10 new model tests pass)bazel test //...passes🤖 Generated with Claude Code