Skip to content

filter None reminders; handle all-day reminders; support 'update' action #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Velesey wants to merge 3 commits into
base: master
Choose a base branch
from
Open

filter None reminders; handle all-day reminders; support 'update' action #7

Velesey wants to merge 3 commits into from

Conversation

@Velesey
Copy link

@Velesey Velesey commented Dec 26, 2020

Sometimes reminders can be None

jonahar
jonahar reviewed Jan 1, 2021
View reviewed changes
reminders_client_utils.py

def update_req_body(reminder: Reminder) -> str:
"""
returns the body of a update-reminder request
Copy link
Owner

@jonahar jonahar Jan 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of an update

jonahar
jonahar reviewed Jan 1, 2021
View reviewed changes
reminders_client.py
'get': 'https://reminders-pa.clients6.google.com/v1internalOP/reminders/get',
'list': 'https://reminders-pa.clients6.google.com/v1internalOP/reminders/list'
'list': 'https://reminders-pa.clients6.google.com/v1internalOP/reminders/list',
'update': 'https://reminders-pa.clients6.google.com/v1internalOP/reminders/update'
Copy link
Owner

@jonahar jonahar Jan 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please end line with ","

jonahar
jonahar reviewed Jan 1, 2021
View reviewed changes
reminders_client_utils.py
creation_timestamp_msec=creation_timestamp_msec,
done_timestamp_msec=done_timestamp_msec,
done=done,
all_day = all_day
Copy link
Owner

@jonahar jonahar Jan 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too, end with ","

jonahar
jonahar requested changes Jan 1, 2021
View reviewed changes
Copy link
Owner

@jonahar jonahar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving this tool Vladimir!
Can you also add the corresponding code for updating a reminder in remind.py so it can easily be used from the cli? (i.e., support one more cli argument). Please also see some minor styling comments.

@jonahar jonahar changed the title filter None reminders filter None reminders; handle all-day reminders; support 'update' action Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonahar jonahar jonahar requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Velesey @jonahar