Merged
Conversation
jonasleitner
force-pushed
the
sympy_import
branch
from
b414be2 to
6dbc829
Compare
jonasleitner
force-pushed
the
sympy_import
branch
from
6dbc829 to
914462c
Compare
Collaborator
LinusBDittmer
left a comment
LinusBDittmer
left a comment
There was a problem hiding this comment.
LGTM save for the implementation of floating points. It's straightforward and the usage of Rational over a float is user-dependent and therefore reasonably generated by to_latex_str().
LinusBDittmer
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AmplitudeandSymmetricTensor