More efficient wicks implementation#6
Merged
LinusBDittmer merged 6 commits intomasterfrom Jul 6, 2025
Merged
Conversation
LinusBDittmer
requested changes
Jul 6, 2025
Collaborator
LinusBDittmer
left a comment
LinusBDittmer
left a comment
There was a problem hiding this comment.
Some more comments in _contract_operator_string would be nice, functionality and implementation is good.
| flattened_idx = ( | ||
| 2 * left_pos * n_total_operators - left_pos * left_pos | ||
| + 2 * right_pos - 3 * left_pos - 2 | ||
| ) // 2 |
Collaborator
There was a problem hiding this comment.
Perhaps we could add a comment on how the formula for flattened_idx works, similar to the docstring explaining how the n_total_operators calculation works?
E.g:
The flattened_idx is calculated by considering the total number of elements in an upper triangular matrix and the number of elements in the triangle formed by the remaining rows.
Owner
Author
There was a problem hiding this comment.
Good idea. I updated the comments
Collaborator
|
LGTM 👍 |
LinusBDittmer
approved these changes
Jul 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... by efficiently caching contraction results.