fix(security): secure admin endpoints with authentication (#99) #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authentication (#99) ## Summary - Implement admin authentication middleware for cache and metrics endpoints - Add X-Admin-Token header-based authentication with constant-time comparison - Apply authentication to 4 vulnerable endpoints: /api/commits/cache/stats, /api/commits/cache/repositories, /api/commits/cache/invalidate, /metrics - Add stricter rate limiting for admin endpoints (100 req/15min) ## Changes - Created adminAuth.ts middleware with timing-attack-safe token validation - Updated config.ts with adminAuth and adminRateLimit configuration - Protected all admin endpoints with requireAdminToken middleware - Added comprehensive unit and integration tests (17 new tests) - Updated .env.example with admin authentication documentation ## Test Plan - ✅ All 856 backend tests pass - ✅ Build and lint pass - ✅ Manual verification: unauthenticated requests return 403 - ✅ Manual verification: authenticated requests succeed - ✅ Manual verification: invalid tokens rejected
|
NiklasSkulll
approved these changes
Nov 20, 2025
NiklasSkulll
deleted the
99-security-cache-admin-endpoints-and-metrics-are-unauthenticated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements admin authentication middleware to secure cache administration endpoints and metrics endpoint, resolving the security vulnerability reported in #99.
Changes
Created adminAuth middleware (
apps/backend/src/middlewares/adminAuth.ts)Updated configuration (
apps/backend/src/config.ts)adminAuthconfiguration withADMIN_AUTH_ENABLEDandREQUIRE_AUTH_FOR_METRICSflagsadminRateLimitwith stricter limits (100 req/15min) for admin endpointsProtected endpoints:
/api/commits/cache/stats- cache statistics/api/commits/cache/repositories- cached repositories list/api/commits/cache/invalidate- cache invalidation/metrics- Prometheus metricsTesting:
Test Plan
Security Considerations
crypto.timingSafeEqual()for constant-time token comparisonConfiguration
Migration Notes
Closes #99