chore: remove isCompressing checking for concurrent compress.#307
Open
yujune wants to merge 2 commits intojonataslaw:masterfrom
Open
chore: remove isCompressing checking for concurrent compress.#307yujune wants to merge 2 commits intojonataslaw:masterfrom
yujune wants to merge 2 commits intojonataslaw:masterfrom
Conversation
yujune
changed the title
yujune
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The current
VideoCompress.compressVideomethod can only be called once at a time due to theisCompressingflag blocking concurrent executions. As a result, usingFuture.wait([VideoCompress.compressVideo(), VideoCompress.compressVideo(), ...])fails.Changes
Removed
isCompressingto allow concurrent executions usingFuture.wait([...]).