GET /resorts Peak Rankings filters (Issue #59)#88
Merged
jonathanstelman merged 1 commit intomainfrom Mar 21, 2026
Merged
Conversation
- has_peak_rankings: boolean filter on whether pr_total is non-null - pr_total_min/max and per-category min/max range params for all 10 PR score dimensions (snow, resiliency, size, terrain_diversity, challenge, lifts, crowd_flow, facilities, navigation, mountain_aesthetic) - pr_lodging, pr_apres_ski, pr_access_road, pr_ability_low, pr_ability_high multi-value categorical params (case-insensitive, same pattern as region) - All range filters exclude resorts with null PR data - pr_total and pr_overall_rank added to ResortSummary response projection - 22 new tests covering all params and composability Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_peak_rankingsboolean filter (based on whetherpr_totalis non-null)pr_total_min/pr_total_maxand per-category min/max range params for all 10 PR score dimensionspr_lodging,pr_apres_ski,pr_access_road,pr_ability_low,pr_ability_highmulti-value categorical filters (same repeated-param pattern asregion)pr_totalandpr_overall_ranktoResortSummaryresponse projectionDesign decisions
has_peak_rankingsexplicitly exposes the null check rather than relying onpr_total_min=1as a proxyTest plan
has_peak_rankings=true/falsefilters correctlypr_total_min/maxrange works; null values excludedpr_totalandpr_overall_rankpresent in responseCloses #59
🤖 Generated with Claude Code