Fix missing tx.Rollback() on error paths (#24)#68
Merged
Conversation
Replace all `defer tx.Commit()` patterns with the idiomatic Go pattern:
- `defer func() { _ = tx.Rollback() }()` as a safety-net at the top
- Explicit `tx.Commit()` with error handling at the end of the success path
For test code in proteus_test.go where all reads use the same tx and
data does not need to persist, a deferred rollback alone is sufficient,
providing better test isolation.
Files fixed: cmd/sample/main.go, cmd/sample-ctx/main.go,
bench/bench_test.go, speed/speed.go, example_test.go, example2_test.go,
mapper_test.go, proteus_test.go (11 instances)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jonbodner
added a commit
that referenced
this pull request
Feb 22, 2026
Replace all `defer tx.Commit()` patterns with the idiomatic Go pattern:
- `defer func() { _ = tx.Rollback() }()` as a safety-net at the top
- Explicit `tx.Commit()` with error handling at the end of the success path
For test code in proteus_test.go where all reads use the same tx and
data does not need to persist, a deferred rollback alone is sufficient,
providing better test isolation.
Files fixed: cmd/sample/main.go, cmd/sample-ctx/main.go,
bench/bench_test.go, speed/speed.go, example_test.go, example2_test.go,
mapper_test.go, proteus_test.go (11 instances)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all
defer tx.Commit()patterns with the idiomatic Go pattern:defer func() { _ = tx.Rollback() }()as a safety-net at the toptx.Commit()with error handling at the end of the success pathFor test code in proteus_test.go where all reads use the same tx and data does not need to persist, a deferred rollback alone is sufficient, providing better test isolation.
Files fixed: cmd/sample/main.go, cmd/sample-ctx/main.go, bench/bench_test.go, speed/speed.go, example_test.go, example2_test.go, mapper_test.go, proteus_test.go (11 instances)