Skip to content

fix decode of stderr lines #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chadawagner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix decode of stderr lines #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ffmpeg/asyncio/ffmpeg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,12 @@ async def _read_stdout(self) -> bytes:
async def _handle_stderr(self) -> str:
assert self._process.stderr is not None

line = b""
async for line in readlines(self._process.stderr):
self.emit("stderr", line.decode())
line = ""
async for line_bytes in readlines(self._process.stderr):
line = line_bytes.decode(errors="backslashreplace")
self.emit("stderr", line)

return line.decode()
return line

def _reraise_exception(self, exception: Exception):
raise exception
9 changes: 5 additions & 4 deletions ffmpeg/ffmpeg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,9 +251,10 @@ def _read_stdout(self) -> bytes:
def _handle_stderr(self) -> str:
assert self._process.stderr is not None

line = b""
for line in readlines(self._process.stderr):
self.emit("stderr", line.decode())
line = ""
for line_bytes in readlines(self._process.stderr):
line = line_bytes.decode(errors="backslashreplace")
self.emit("stderr", line)

self._process.stderr.close()
return line.decode()
return line