Add support for collapsing PHP Xdebug traces#253
Add support for collapsing PHP Xdebug traces#253MaartenStaa wants to merge 26 commits intojonhoo:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 87.32% 86.82% -0.51%
==========================================
Files 18 19 +1
Lines 2525 2687 +162
==========================================
+ Hits 2205 2333 +128
- Misses 320 354 +34
Continue to review full report at Codecov.
|
7ce3648 to
45bde9f
Compare
|
Hello @MaartenStaa are you still interested in working on this? I would be interested in having this in an inferno release as I am still stuck on some old PHP version (PHP 7.4 on Rocky 8) and that does not have the xdebug.trace_format=3 (I assume your PR is for the trace_format=1). @jonhoo are you still interested in including this code in inferno? Note that new PHP versions can natively produce a proper flamegraph trace with the xdebug.trace_format=3. But it might still be valuable for people that can not yet use xdebug >= 3.3.0. |
Inspired by and continued from #126 by @daniellockyer
This PR is a bit different, because in the meantime Xdebug 3 was released, which apparently introduced a new tracing format as far as I can tell based on the samples I've taken, and the old code. One caveat is that Xdebug actually produces gzipped files, which is not (yet) handled here, as it seems a bit out of scope for this tool.
I went through the comments on the old PR and think I've tackled them all, but please let me know if you have any other feedback.
Also, I love your streams and your book, keep up the great work :)