consider sample count when parsing folded line when using base option#304
Open
conectado wants to merge 1 commit intojonhoo:mainfrom
Open
consider sample count when parsing folded line when using base option#304conectado wants to merge 1 commit intojonhoo:mainfrom
base option#304conectado wants to merge 1 commit intojonhoo:mainfrom
Conversation
Owner
|
Ah, good catch! Would you mind including a test case for this too so we make sure this doesn't regress in the future? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When filtering lines given the
baseoption, the line was parsed using;but given that a space-separated sample count could be included the first iterated value was always ignored to consider whether or not it's part of the base. This caused all the base samples that are leaves to be ignored, this PR fixed that by first splitting using a whitespace.