refactor #186
Open
refactor #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've had some success with automated testing here: https://github.com/willstott101/django-sublime-syntax Would it be helpful if I open a PR which includes tests? - A huge improvement to maintainability IMO EDIT: I say that as large refactors like this would be a lot less scary. |
Owner
Author
|
@willstott101 that would be great! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for feedback on this before I merge. Please let me know if you experience issues.
Edit: I plan on re-visiting pull requests after this is merged, I'm sorry for any inconvenience to anyone who did PRs, but I wanted to at least get this package updated and maintainable first.