Closes #20 :Add Tags to every uploaded asset #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joojoooo
requested changes
Jul 18, 2025
README.md
Outdated
| - `-checksums_file`: Path to the checksums file (default: `checksums.csv`) | ||
| - `-download_jpg_from_jxl`: Converts JXL images to JPG on download for compatibility (default: `false`) | ||
| - `-download_jpg_from_avif`: Converts AVIF images to JPG on download for compatibility (default: `false`) | ||
| - `-tag-ids`: Comma-separated list of tag IDs to add to every asset (default: `""`) |
| req.Header.Set("Content-Type", multipartWriter.FormDataContentType()) | ||
| // Send the request to the upstream server | ||
| resp, err := getHTTPclient().Do(req) | ||
| defer resp.Body.Close() |
Owner
There was a problem hiding this comment.
why move this defer? can return without closing body on error
Author
There was a problem hiding this comment.
Because I thought it better to check for errors before deferring.
| return fmt.Errorf("no asset ID found in upstream response") | ||
| } | ||
| // Tag the asset | ||
| if len(tagIDs) > 0 { |
Author
There was a problem hiding this comment.
what do you suggest? Either way a check has to be put here to see whether this request is needed or not since it should be optional for users to add tags or not.
jobs.go
Outdated
|
|
||
| // Create tag request | ||
| tagURL := fmt.Sprintf("%s/api/tags/assets", upstreamURL) | ||
| tagReq, err := http.NewRequestWithContext(ctx, "PUT", tagURL, bytes.NewReader(tagBodyBytes)) |
main.go
Outdated
|
|
||
| // goreleaser auto updated vars | ||
| var version = "dev" | ||
| var version = "v0.8.1" |
main.go
Outdated
| } else { | ||
| log.Printf("no tmp directory set, uploaded files will be saved on disk multiple times, this can shorten your disk lifespan !") | ||
| } | ||
| // Process tags |
| } | ||
|
|
||
| // getTagIDs parses tagIDsStr into a list of tag IDs | ||
| func getTagIDs() ([]string, error) { |
Owner
There was a problem hiding this comment.
I would just enforce a strict formatting, user error if they put spaces
Author
There was a problem hiding this comment.
done, kept a check to make it easier to debug.
main.go
Outdated
| flag.StringVar(&checksumsFile, "checksums_file", viper.GetString("checksums_file"), "Path to the checksums file") | ||
| flag.BoolVar(&downloadJpgFromJxl, "download_jpg_from_jxl", viper.GetBool("download_jpg_from_jxl"), "Converts JXL images to JPG on download for wider compatibility") | ||
| flag.BoolVar(&downloadJpgFromAvif, "download_jpg_from_avif", viper.GetBool("download_jpg_from_avif"), "Converts AVIF images to JPG on download for wider compatibility") | ||
| flag.StringVar(&tagIDsStr, "tag-ids", viper.GetString("tag_ids"), "Comma-separated list of tag IDs") |
jobs.go
Outdated
| tagReq.AddCookie(cookie) | ||
| } | ||
| // Copy other headers that might be relevant for authentication | ||
| if apiKey := originalReq.Header.Get("x-api-key"); apiKey != "" { |
Owner
There was a problem hiding this comment.
there is helper functions to copy all headers/cookies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to let the user add a list of tags to every uploaded assets.
This is quite useful since it is a pain to set up a separate logic to bulk tag assets for multiple reasons:
/search/metadatacontains assetIDs but not tags, not even whether it has tags or not likehasMetadata.Let me know what you think about this.
If needed I can add the possibility to use tag names instead of IDs and make sure they exist before tagging assets.