[4.0] Deprecated class attribute #348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
reviewed
Oct 6, 2025
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Contributor
|
I think this should trigger an custom deprecation message if the input is not \stdClass, since no IDE or analyser understands parameter deprecation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #254
Summary of Changes
In Meeting 106 of the maintainers team the team decided to remove the class parameter from loadObject, loadObjectList and DatabaseIterator.
This way (ussing a custom class as result) of fetching data is not supported over all database drivers so it can lead to problems in the development and using the database package.
Testing Instructions
No tests possible it is ony documenting that the parameter is deprecated and will be removed with version 6 of the package.
Documentation Changes Required
No changes needed it is so widly used that it wasn't part of the documentation ;-)