This repository was archived by the owner on May 10, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 3
Feature - Workflows for com_modules #10
Open
YatharthVyas
wants to merge
66
commits into
joomla-projects:dev
Choose a base branch
from
YatharthVyas:feature-module-workflow
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature - Workflows for com_modules #10
YatharthVyas
wants to merge
66
commits into
joomla-projects:dev
from
YatharthVyas:feature-module-workflow
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Vyas/gsoc21_core-enhancements into feature-module-workflow
I've approved the SQL parts only, I did not much review on other things. |
The duplicate queries in the update SQL I haven't noticed 😄 . |
richard67
reviewed
Aug 2, 2021
richard67
reviewed
Aug 2, 2021
richard67
suggested changes
Aug 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix wrong quoting causing SQL syntax error on PostgreSQL.
administrator/components/com_content/src/Model/ArticlesModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
suggested changes
Aug 8, 2021
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
reviewed
Aug 8, 2021
richard67
reviewed
Aug 8, 2021
administrator/components/com_modules/src/Model/ModulesModel.php
Outdated
Show resolved
Hide resolved
richard67
approved these changes
Aug 8, 2021
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
reviewed
Aug 8, 2021
administrator/components/com_modules/src/Model/ModulesModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
reviewed
Aug 8, 2021
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
richard67
reviewed
Aug 8, 2021
administrator/components/com_content/src/Model/ArticlesModel.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Thank you for testing @winniecarole I like your suggestion for checking duplicate workflow names. I believe this change is related to Workflows as a whole and it should be addressed in a PR aiming for that. I will make sure to add this to my future roadmap :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a substitute for Task 3. The aim of this PR is to incorporate Workflows in com_modules
Summary of Changes
ContentHelper:onPrepareForm
to ModuleModel. This function adds the default workflow option to the workflow dropdownNeeds work:
Testing Instructions
After a fresh install:
1, Go to Modules -> Options -> Integrations and Enable Workflows
2. Test the transitions in modules view
3. Test CRUD for workflows, stages and transitions in Modules: Workflows
Expected result AFTER applying this Pull Request
Workflows implemented
Documentation Changes Required
Yes. Something on the lines of https://docs.joomla.org/Publishing_Workflow_Implementation#Implement_com_workflow_into_your_extension