Use node.remove() instead of parent.removeChild(node)#1036
Open
skanne wants to merge 1 commit intojorgebucaran:mainfrom
Open
Use node.remove() instead of parent.removeChild(node)#1036skanne wants to merge 1 commit intojorgebucaran:mainfrom
skanne wants to merge 1 commit intojorgebucaran:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jorge,
not sure if you still want to support olden and not-at-all-golden Internet Explorer. If you're ditching it, then we could as well inch ourselves closer to more modern JS.
Here I am suggesting replacing the pattern
parent.removeChild(node)with the simplernode.remove(). According to CanIUse it is safe to assume that by now this method is supported by all non-IE-browsers out there.Benefit: We can shave off a few more bytes.
Regards,
Sven