This repository was archived by the owner on Feb 18, 2024. It is now read-only.
Added try_new for mutable data types#1589
Open
aryanshomray wants to merge 5 commits intojorgecarleitao:mainfrom
Open
Added try_new for mutable data types#1589aryanshomray wants to merge 5 commits intojorgecarleitao:mainfrom
aryanshomray wants to merge 5 commits intojorgecarleitao:mainfrom
Conversation
aldanor
reviewed
Nov 6, 2023
| M::Type: Eq + Hash, | ||
| { | ||
| let map = ValueMap::<K, M>::from_values(values)?; | ||
| Ok(Self { |
Contributor
There was a problem hiding this comment.
Hm... shouldn't data_type be validated here?
Contributor
There was a problem hiding this comment.
No, I think what you need to check is that ValueMap's resulting data type is the same as data type being passed in?
aryanshomray
force-pushed
the
ary/add_try_new
branch
from
fa0b581 to
ac5f5d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is made to have consistent in try_new() constructors that accept DataType in a similar way, for all mutable array types