Skip to content

Allows for depots with non-default stream depths#13

Draft
thejustinwalsh wants to merge 2 commits intojorgenpt:mainfrom
thejustinwalsh:issue-12
Draft

Allows for depots with non-default stream depths#13
thejustinwalsh wants to merge 2 commits intojorgenpt:mainfrom
thejustinwalsh:issue-12

Conversation

@thejustinwalsh
Copy link
Contributor

Fix for issue #12.

  • It may not be idiomatic rust.
  • The logic could likely be simplified, as the stream name without the depot prefixed is not emitted from the function.
  • Tests ensure it works like it used to while supporting bespoke stream depth setups.

@thejustinwalsh
Copy link
Contributor Author

Added logic to migrate any existing projects that are using a non-defaul stream depth.

@parnic-sks
Copy link

🚀 👍

@thejustinwalsh thejustinwalsh marked this pull request as draft July 25, 2024 17:46
@thejustinwalsh
Copy link
Contributor Author

While this appears to make the DB entries look correct, it did not work once I did a test deployment.
I might need @jorgenpt's help on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants