Skip to content

Conversation

@josdem
Copy link
Owner

@josdem josdem commented Apr 18, 2025

  • Setting value from action result
  • Improving some code
  • Updating version

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve logging and string concatenation practices by replacing StringBuilder constructs with simpler concatenation and parameterized logging calls, while also removing some unused imports.

  • Improved logging statements with SLF4J parameters
  • Replaced verbose StringBuilder usage with simple concatenation
  • Renamed variable names for clarity in several methods
Comments suppressed due to low confidence (2)

src/main/java/com/josdem/jmetadata/gui/MainWindow.java:245

  • Method name 'onCovertArtFailed' appears to contain a typo. Consider renaming it to 'onCoverArtFailed' for clarity.
void onCovertArtFailed(String title) {

src/main/java/com/josdem/jmetadata/gui/MainWindow.java:239

  • [nitpick] The variable name 'sb' is ambiguous in this context. Consider renaming it to 'message' to better reflect its usage.
String sb = ApplicationConstants.LOGGED_AS + currentUser.getUsername();

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@josdem josdem merged commit 1a24b11 into main Apr 19, 2025
2 of 3 checks passed
@josdem josdem deleted the feature/126 branch April 19, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants