-
Notifications
You must be signed in to change notification settings - Fork 6
[large]Feature/118-A #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[large]Feature/118-A #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces several changes focused on enhancing testing and dependency injection while updating versioning. Key changes include:
- Migrating helper tests from Java to Kotlin.
- Updating dependency injection in several Java components by leveraging Lombok’s @requiredargsconstructor and adding missing Spring annotations.
- Rearranging test classes into the appropriate packages.
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/com/josdem/jmetadata/helper/ImageExporterTest.kt | New Kotlin test implementation for image exporting functionality. |
| src/test/java/com/josdem/jmetadata/helper/FormatterHelperTest.kt | New Kotlin test for the FormatterHelper replacing the Java version. |
| src/test/java/com/josdem/jmetadata/helper/ExporterHelperTest.kt | Kotlin test for ExporterHelper demonstrating combined image and metadata exporting. |
| src/test/java/com/josdem/jmetadata/helper/AudioFileHelperTest.kt | Ported test for audio file reading implemented in Kotlin. |
| src/test/java/com/josdem/jmetadata/helper/ArtworkHelperTest.kt | Kotlin test for artwork creation, replacing existing Java version. |
| src/test/java/com/josdem/jmetadata/helper/ApplicationContextSingletonTest.kt | Updated application context test in Kotlin verifying bean creation. |
| src/main/java/com/josdem/jmetadata/service/impl/LastFMCompleteServiceImpl.java | Updated to use LocalDate conversion for setting year metadata. |
| src/main/java/com/josdem/jmetadata/helper/ScrobblerHelper.java | Fixed typo in constant naming and updated log messages. |
| src/main/java/com/josdem/jmetadata/helper/OutStreamWriter.java | Added Spring @component annotation. |
| src/main/java/com/josdem/jmetadata/helper/MetadataExporter.java | Updated dependency injection to use final fields and logging improvements. |
| src/main/java/com/josdem/jmetadata/helper/LastFMTrackHelper.java | Added @component annotation. |
| src/main/java/com/josdem/jmetadata/helper/LastFMAuthenticator.java | Updated DI to use Lombok’s @requiredargsconstructor. |
| src/main/java/com/josdem/jmetadata/helper/LastFMAlbumHelper.java | Refactored getYear to accept LocalDate for better type safety. |
| src/main/java/com/josdem/jmetadata/helper/ExporterHelper.java | Updated dependency injection using final fields and Lombok’s @requiredargsconstructor. |
Comments suppressed due to low confidence (1)
src/main/java/com/josdem/jmetadata/helper/MetadataExporter.java:68
- The method getFirst() is not defined for java.util.List; consider using get(0) to access the first element.
writer.write(metadataList.getFirst().getAlbum().getBytes());
|



@Componentannotations