Use "populate" instead of "transpose" for pin filter #1602
Merged
+7
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/rm-transpose
branch
2 times, most recently
from
3a1b22d to
97e598f
Compare
vlad-ivanov-name
approved these changes
Nov 17, 2025
We didn't realize that we can use those existing functions instead of creating a new one. Going via pathstree() and populate() might not be the absolute best possible route, but those use memoization and should be much faster for repeated application that the transpose() which always needs to look at all paths.
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/rm-transpose
branch
from
97e598f to
d9e716b
Compare
christian-schilling
deleted the
@changes/master/christian.schilling.de@gmail.com/rm-transpose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't realize that we can use those existing functions instead
of creating a new one.
Going via pathstree() and populate() might not be the absolute best possible
route, but those use memoization and should be much faster for repeated
application that the transpose() which always needs to look at all paths.