Skip to content

feat: add feature toggle for notification banner #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshydavid merged 4 commits into from
Aug 1, 2025
Merged

feat: add feature toggle for notification banner #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3fcad6
feat: add banner component
joshydavid Aug 1, 2025
7c4fe94
fix: use absolute path
joshydavid Aug 1, 2025
d16af0f
feat: add feature toggle for notification banner
joshydavid Aug 1, 2025
3eec9b9
chore: use env variable for banner message
joshydavid Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/.env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
NEXT_PUBLIC_API_BASE_URL=https://brew.joshydavid.com/api/v1
NEXT_PUBLIC_S3_IMAGE_URL=https://your-bucket.s3.region.amazonaws.com
NEXT_PUBLIC_NOTIFICATION_BANNER=true
NEXT_PUBLIC_BANNER_MESSAGE="⚠️ Notice: AWS resources have been spun down. The backend is currently not running."
13 changes: 9 additions & 4 deletions frontend/app/components/Header/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,18 @@ import { usePathname } from "next/navigation";
export default function Header() {
const pathname = usePathname();
const { authData } = useAuthStatus();
const showBanner = process.env.NEXT_PUBLIC_NOTIFICATION_BANNER === "true";
Copy link

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a more robust configuration approach. Direct environment variable access makes testing difficult and creates tight coupling. Consider creating a configuration utility function or using a configuration context that can be easily mocked in tests.

Copilot uses AI. Check for mistakes.

return (
<>
<BannerComponent
title="⚠️&nbsp; Notice: AWS resources have been spun down. The backend is
currently not running."
/>
{showBanner && (
<BannerComponent
title={
process.env.NEXT_PUBLIC_BANNER_MESSAGE ||
"Notice: AWS resources have been spun down. The backend is currently not running."
}
/>
)}
<header className="flex flex-row items-center justify-between px-4 py-6 md:px-6">
<div>{pathname !== "/" && <BackButton />}</div>
<div className="flex items-center gap-2">
Expand Down